run black and blackdoc #4381
run black and blackdoc #4381
Conversation
|
Do we need to change the pre-commit versions? I guess CI pulls latest and so that automatically updates? |
I don't think so, we're using the The only thing we can change in this PR is the trailing comma, so it would be good to review that. |
|
Ah, sorry, it's only LGTM! |
|
actually, everything except |
Do you think they should be? It's going to be a difficult error to debug for folks who don't know the tools well, if there are backward / forward incompatible changes (maybe there aren't any though?) |
| @@ -56,7 +56,9 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| def broadcast_dimension_size(variables: List[Variable],) -> Dict[Hashable, int]: | |||
| def broadcast_dimension_size( | |||
| variables: List[Variable], | |||
There was a problem hiding this comment.
seems unnecessary
| variables: List[Variable], | |
| variables: List[Variable] |
| @@ -322,7 +322,9 @@ def _assert_dataset_invariants(ds: Dataset): | |||
| assert isinstance(ds._attrs, (type(None), dict)) | |||
|
|
|||
|
|
|||
| def _assert_internal_invariants(xarray_obj: Union[DataArray, Dataset, Variable],): | |||
| def _assert_internal_invariants( | |||
| xarray_obj: Union[DataArray, Dataset, Variable], | |||
There was a problem hiding this comment.
| xarray_obj: Union[DataArray, Dataset, Variable], | |
| xarray_obj: Union[DataArray, Dataset, Variable] |
also unnecessary?
|
hahaha no worries. |
|
D'oh @dcherian ! |
blackchanged their style (format docstrings and trailing comma handling mostly) in their new release. This simply runs that new version ofblackon the repository.This is a separate PR so reviewing becomes easier.
Since it is an automatic change, this should be ready to be merged once the CI is green.