Add inclusive argument to cftime_range and date_range and deprecate closed argument
#7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
commented
Jan 22, 2023
spencerkclark
force-pushed
the
inclusive
branch
from
9cd335d
to
3f86d33
Compare
keewis
reviewed
Jan 23, 2023
1 task
dcherian
reviewed
Jan 25, 2023
spencerkclark
force-pushed
the
inclusive
branch
3 times, most recently
from
7a291c6
to
a366269
Compare
RTD failure is still real :( |
dcherian
reviewed
Jan 31, 2023
Co-authored-by: Justus Magin <keewis@users.noreply.github.com>
spencerkclark
force-pushed
the
inclusive
branch
from
9486747
to
1f0dc88
Compare
|
After debugging locally it looks like the remaining doc build failure was the result of a line I inadvertently deleted further down in the |
spencerkclark
commented
Feb 4, 2023
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
|
Thanks @spencerkclark . I didn't realize we had the pandas copyright notice in |
dcherian
added a commit
to bzah/xarray
that referenced
this pull request
Feb 28, 2023
* upstream/main: (291 commits) Update error message when saving multiindex (pydata#7475) DOC: cross ref the groupby tutorial (pydata#7555) [pre-commit.ci] pre-commit autoupdate (pydata#7543) supress namespace_package deprecation warning (doctests) (pydata#7548) [skip-ci] Add PDF of Xarray logo (pydata#7530) Support complex arrays in xr.corr (pydata#7392) clarification for thresh arg of dataset.dropna() (pydata#7481) [pre-commit.ci] pre-commit autoupdate (pydata#7524) Require to explicitly defining optional dimensions such as hue and markersize (pydata#7277) Use plt.rc_context for default styles (pydata#7318) Update HOW_TO_RELEASE.md (pydata#7512) Update whats-new for dev (pydata#7511) Fix whats-new for 2023.02.0 (pydata#7506) Update apply_ufunc output_sizes error message (pydata#7509) Zarr: drop "source" and "original_shape" from encoding (pydata#7500) [pre-commit.ci] pre-commit autoupdate (pydata#7507) Whats-new for 2023.03.0 Add `inclusive` argument to `cftime_range` and `date_range` and deprecate `closed` argument (pydata#7373) Make text match code example (pydata#7499) Remove Dask single-threaded setting in tests (pydata#7489) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following pandas, this PR adds an
inclusiveargument toxarray.cftime_rangeandxarray.date_rangeand deprecates theclosedargument. Pandas will be removing theclosedargument soon in theirdate_rangeimplementation, but we will continue supporting it to allow for our own deprecation cycle.I think we may also need to update our minimum pandas version to 1.4 for this, since earlier versions of pandas do not support the
inclusiveargument.whats-new.rst