Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing 'dim' argument in _get_nan_block_lengths #7598

Merged
merged 7 commits into from
Mar 16, 2023
Merged

Fix missing 'dim' argument in _get_nan_block_lengths #7598

merged 7 commits into from
Mar 16, 2023

Conversation

Ockenfuss
Copy link
Contributor

@Ockenfuss Ockenfuss commented Mar 8, 2023 •
edited by dcherian
Loading

  • Add missing dim argument (GH7597)
  • Append a nan gap at the end of existing tests cases

Paul Ockenfuss added 2 commits March 8, 2023 18:00
Fix missing 'dim' argument in _get_nan_block_lengths
e6989ff 
* Add missing dim argument (GH7597)
* Append a nan gap at the end of existing tests cases
Explicitly call 'dim' by keyword
3029b22
@Ockenfuss
Copy link
Contributor Author

Ockenfuss commented Mar 8, 2023 •
edited
Loading

As a newcomer, a short general question: The 'Contributing' guide mentions to document changes in whats-new.rst. Shall this be done by the developer or are you (the maintainers) doing this once the PR is merged into the main branch?

(Since at the time of requesting, I can`t know when (or if) the issue will be merged).

@headtr1ck
Copy link
Collaborator

As a newcomer, a short general question: The 'Contributing' guide mentions to document changes in whats-new.rst. Shall this be done by the developer or are you (the maintainers) doing this once the PR is merged into the main branch?

(Since at the time of requesting, I can`t know when (or if) the issue will be merged).

Usually this is done by the developer/contributor. You can just copy a similar entry and adopt it to yourself in the newest section, you have basically full freedom :)

@Ockenfuss
Copy link
Contributor Author

As a newcomer, a short general question: The 'Contributing' guide mentions to document changes in whats-new.rst. Shall this be done by the developer or are you (the maintainers) doing this once the PR is merged into the main branch?
(Since at the time of requesting, I can`t know when (or if) the issue will be merged).

Usually this is done by the developer/contributor. You can just copy a similar entry and adopt it to yourself in the newest section, you have basically full freedom :)

Thanks, good to know!

dcherian
dcherian approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ockenfuss This looks great!

Welcome to Xarray!

headtr1ck
headtr1ck approved these changes Mar 13, 2023
View reviewed changes
xarray/core/missing.py Outdated Show resolved Hide resolved
dcherian
dcherian reviewed Mar 14, 2023
View reviewed changes
xarray/core/missing.py Outdated Show resolved Hide resolved
@dcherian dcherian added the plan to merge Final call for comments label Mar 14, 2023
@dcherian dcherian merged commit 70c8534 into pydata:main Mar 16, 2023
@Ockenfuss Ockenfuss deleted the fix-missing-dimensionname-max_gap branch March 23, 2023 16:04
dcherian added a commit to dcherian/xarray that referenced this pull request Mar 26, 2023
@dcherian
Merge branch 'main' into kvikio
517f195 
* main: (40 commits)
  Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638)
  add timeouts for tests (pydata#7657)
  Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667)
  [pre-commit.ci] pre-commit autoupdate (pydata#7651)
  Allow all integer dtypes in `polyval` (pydata#7619)
  [skip-ci] dev whats-new (pydata#7660)
  Redo whats-new for 2023.03.0 (pydata#7659)
  Set copy=False when calling pd.Series (pydata#7642)
  Pin pandas < 2 (pydata#7650)
  Whats-new for release 2023.03.0 (pydata#7643)
  Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648)
  Use more descriptive link texts (pydata#7625)
  Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598)
  Fix `pcolormesh` with str coords (pydata#7612)
  [skip-ci] Fix groupby binary ops benchmarks (pydata#7603)
  Remove incomplete sentence in IO docs (pydata#7631)
  Allow indexing unindexed dimensions using dask arrays (pydata#5873)
  Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618)
  [pre-commit.ci] pre-commit autoupdate (pydata#7620)
  add a test for scatter colorbar extend (pydata#7616)
  ...
dcherian added a commit to kmsquire/xarray that referenced this pull request Mar 29, 2023
@dcherian
Merge remote-tracking branch 'upstream/main' into feature/rolling-pad
28a4ad2 
* upstream/main: (716 commits)
  Faq pull request (According to pull request pydata#7604 & issue pydata#1285 (pydata#7638)
  add timeouts for tests (pydata#7657)
  Pull Request Labeler - Undo workaround sync-labels bug (pydata#7667)
  [pre-commit.ci] pre-commit autoupdate (pydata#7651)
  Allow all integer dtypes in `polyval` (pydata#7619)
  [skip-ci] dev whats-new (pydata#7660)
  Redo whats-new for 2023.03.0 (pydata#7659)
  Set copy=False when calling pd.Series (pydata#7642)
  Pin pandas < 2 (pydata#7650)
  Whats-new for release 2023.03.0 (pydata#7643)
  Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 (pydata#7648)
  Use more descriptive link texts (pydata#7625)
  Fix missing 'dim' argument in _get_nan_block_lengths (pydata#7598)
  Fix `pcolormesh` with str coords (pydata#7612)
  [skip-ci] Fix groupby binary ops benchmarks (pydata#7603)
  Remove incomplete sentence in IO docs (pydata#7631)
  Allow indexing unindexed dimensions using dask arrays (pydata#5873)
  Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 (pydata#7618)
  [pre-commit.ci] pre-commit autoupdate (pydata#7620)
  add a test for scatter colorbar extend (pydata#7616)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpolate_na: max_map argument not working at array boundaries
3 participants
@Ockenfuss @headtr1ck @dcherian