Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dtype of reindex result matches dtype of the original DataArray #7917

Merged
merged 2 commits into from Jun 16, 2023
Merged

Ensure dtype of reindex result matches dtype of the original DataArray #7917

merged 2 commits into from Jun 16, 2023

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Jun 13, 2023 •
edited

headtr1ck
headtr1ck approved these changes Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry in whats-new

@dcherian dcherian added the plan to merge Final call for comments label Jun 14, 2023
@dcherian dcherian merged commit 71defdd into pydata:main Jun 16, 2023
29 checks passed
@andersy005 andersy005 deleted the bug-fix-dtype-promotion branch June 16, 2023 22:51
dstansby pushed a commit to dstansby/xarray that referenced this pull request Jun 28, 2023
@andersy005 @dstansby
Ensure dtype of reindex result matches dtype of the original DataArray (
2697150 
pydata#7917)

* Ensure dtype of reindex result matches dtype of the original DataArray

* update what's new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataArray.reindex of empty array changes dtype from float32 to float64
3 participants
@andersy005 @dcherian @headtr1ck