Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) min versions bump #8022

Merged
merged 6 commits into from Jul 27, 2023
Merged

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Jul 26, 2023

  • User visible changes (including notable bug fixes) are documented in whats-new.rst

@github-actions github-actions bot added CI Continuous Integration tools dependencies Pull requests that update a dependency file labels Jul 26, 2023
Copy link
Member Author

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last commit removed some obvious deprecations and version switches.

@dcherian and @andersy005 - would appreciate a second look at this when you get a chance.

xarray/coding/cftimeindex.py Show resolved Hide resolved
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you push updates to conda-forge/xarray-feedstock#84. Perhaps we should merge that at our next release.

Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhamman, this looks great to me --- i just pushed some updates with changes in tests

@jhamman
Copy link
Member Author

jhamman commented Jul 27, 2023

LGTM. Can you push updates to conda-forge/xarray-feedstock#84. Perhaps we should merge that at our next release.

Done. We should use that PR for the next release (as you suggest).

@jhamman jhamman merged commit db12b0d into pydata:main Jul 27, 2023
29 checks passed
@jhamman jhamman deleted the bump-min-versions-0723 branch July 27, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tools dependencies Pull requests that update a dependency file io topic-backends topic-cftime topic-combine combine/concat/merge topic-groupby topic-rolling topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants