Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override units for datetime64/timedelta64 variables to preserve integer dtype #8201

Merged
merged 22 commits into from Sep 24, 2023
Merged

override units for datetime64/timedelta64 variables to preserve integer dtype #8201

merged 22 commits into from Sep 24, 2023

Commits on Sep 19, 2023

  1. remove dtype from encoding for datetime64/timedelta64 variables to … 

    …prevent unnecessary casts
    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    37db2b0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    490b186 View commit details
    Browse the repository at this point in the history

  3. adapt tests

    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    aff4e63 View commit details
    Browse the repository at this point in the history

  4. add whats-new.rst entry

    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f6a954c View commit details
    Browse the repository at this point in the history

  5. Update xarray/coding/times.py 

    Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
    @kmuehlbauer @spencerkclark
    kmuehlbauer and spencerkclark committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e8de234 View commit details
    Browse the repository at this point in the history

  6. Update doc/whats-new.rst 

    Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
    @kmuehlbauer @spencerkclark
    kmuehlbauer and spencerkclark committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    b19a0e2 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7c19267 View commit details
    Browse the repository at this point in the history

  8. add test per review suggestion, replace .kind-check with np.issubdtyp… 

    …e-check
    @kmuehlbauer
    kmuehlbauer committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    fc63ed9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. align timedelta64 check with datetime64 check

    @kmuehlbauer
    kmuehlbauer committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    35b77d6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    ebd2e9a View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    6691bfa View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. override units instead of dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    64e2087 View commit details
    Browse the repository at this point in the history

  2. remove print statement

    @kmuehlbauer
    kmuehlbauer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f3ca8bf View commit details
    Browse the repository at this point in the history

  3. warn in case of serialization to floating point, too

    @kmuehlbauer
    kmuehlbauer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    90d4e0c View commit details
    Browse the repository at this point in the history

  4. align if-else

    @kmuehlbauer
    kmuehlbauer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4340884 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Add instructions to warnings

    @kmuehlbauer
    kmuehlbauer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    a7ba341 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    9e25c3a View commit details
    Browse the repository at this point in the history

  3. Fix test

    @kmuehlbauer
    kmuehlbauer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    f4b3153 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    32461c0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into drop-time-dtype

    @kmuehlbauer
    kmuehlbauer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    410b9de View commit details
    Browse the repository at this point in the history

  6. use warnings.catch_warnings

    @kmuehlbauer
    kmuehlbauer committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    43664c9 View commit details
    Browse the repository at this point in the history

  7. Update doc/whats-new.rst 

    Co-authored-by: Spencer Clark <spencerkclark@gmail.com>
    @kmuehlbauer @spencerkclark
    kmuehlbauer and spencerkclark committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    33a3e1a View commit details
    Browse the repository at this point in the history