Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception in to_dataset if resulting variable is also the name of a coordinate #8433

Merged
merged 5 commits into from Nov 14, 2023
Merged

Raise exception in to_dataset if resulting variable is also the name of a coordinate #8433

merged 5 commits into from Nov 14, 2023

Commits on Nov 14, 2023

  1. Add tests for issue pydata#7823

    @mgunyho
    mgunyho committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    4673c78 View commit details
    Browse the repository at this point in the history

  2. Use 2D array to properly test to_dataset error handling logic

    @mgunyho
    mgunyho committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    303e88f View commit details
    Browse the repository at this point in the history

  3. Raise exception if a variable is also a coordinate in to_dataset 

    Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
    @mgunyho @dcherian
    mgunyho and dcherian committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    08a57ba View commit details
    Browse the repository at this point in the history

  4. Update whats-new

    @mgunyho
    mgunyho committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2042ef9 View commit details
    Browse the repository at this point in the history

  5. Ensure that coordinates are in the original order

    @mgunyho
    mgunyho committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a9a45bb View commit details
    Browse the repository at this point in the history