Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use first element of residual in _nonpolyfit_1d #8647

Merged
merged 1 commit into from Jan 23, 2024

Conversation

Zeitsperre
Copy link
Contributor

This is a very small change to silence a numpy-related warning. If more information/documentation is needed, I can adjust as needed!

@Zeitsperre
Copy link
Contributor Author

FYI @aulemahal

@max-sixty
Copy link
Collaborator

Thanks!

FYI failure is unrelated.

If you remember, can we note down here the warning that was silenced?

@max-sixty max-sixty merged commit 75075c8 into pydata:main Jan 23, 2024
25 of 28 checks passed
@Zeitsperre
Copy link
Contributor Author

@max-sixty Thanks! The error from my builds:

.../xarray/core/nputils.py:237: DeprecationWarning: Conversion of an array with ndim > 0 to a scalar is deprecated, and will error in future. Ensure you extract a single element from your array before performing this operation. (Deprecated NumPy 1.25.)
    out[-1] = resid if resid.size > 0 else np.nan

@max-sixty
Copy link
Collaborator

max-sixty commented Jan 24, 2024

Super; thanks @Zeitsperre

Fixing warnings is v appreciated! If you spot others you know how to resolve that's helpful!

andersy005 added a commit to TomNicholas/xarray that referenced this pull request Jan 30, 2024
* main: (153 commits)
  Add overloads to get_axis_num (pydata#8547)
  Fix CI: temporary pin pytest version to 7.4.* (pydata#8682)
  Bump the actions group with 1 update (pydata#8678)
  [namedarray] split `.set_dims()` into `.expand_dims()` and `broadcast_to()` (pydata#8380)
  Add chunk-friendly code path to `encode_cf_datetime` and `encode_cf_timedelta` (pydata#8575)
  Fix NetCDF4 C version detection (pydata#8675)
  groupby: Don't set `method` by default on flox>=0.9 (pydata#8657)
  Fix automatic broadcasting when wrapping array api class (pydata#8669)
  Fix unstack method when wrapping array api class (pydata#8668)
  Fix `variables` arg typo in `Dataset.sortby()` docstring (pydata#8670)
  dt.weekday_name - removal of function (pydata#8664)
  Add `dev` dependencies to `pyproject.toml` (pydata#8661)
  CI: Pin scientific-python/upload-nightly-action to release sha (pydata#8662)
  Update HOW_TO_RELEASE.md by clarifying where RTD build can be found (pydata#8655)
  ruff: use extend-exclude (pydata#8649)
  new whats-new section (pydata#8652)
  xfail another test on windows (pydata#8648)
  use first element of residual in _nonpolyfit_1d (pydata#8647)
  whatsnew for v2024.01.1
  implement `isnull` using `full_like` instead of `zeros_like` (pydata#7395)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants