Don't access data when creating DataArray from Variable. #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dcherian for the quick fix! |
TomNicholas
reviewed
Feb 15, 2024
| @@ -4908,7 +4908,7 @@ def test_idxmin( | |||
| with pytest.raises(ValueError): | |||
| xr.DataArray(5).idxmin() | |||
|
|
|||
| coordarr0 = xr.DataArray(ar0.coords["x"], dims=["x"]) | |||
| coordarr0 = xr.DataArray(ar0.coords["x"].data, dims=["x"]) | |||
There was a problem hiding this comment.
I'm unclear why this needs to be changed?
andersy005
approved these changes
Feb 16, 2024
|
necro bump on this, would be great to have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataArrayvs.Variable#8753This seems to have been around since 2016-ish, so presumably our backend code path is passing arrays around, not Variables.
cc @ilan-gold