Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate datatree.py module into xarray.core. #8789

Merged
merged 27 commits into from
Mar 26, 2024
Merged

Migrate datatree.py module into xarray.core. #8789

merged 27 commits into from
Mar 26, 2024

Commits on Mar 4, 2024

  1. Migrate datatree.py module into xarray.core.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    ed47ffd View commit details
    Browse the repository at this point in the history

  2. Add correct PR reference to whats-new.rst.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0784196 View commit details
    Browse the repository at this point in the history

  3. Revert to using Union in datatree.py.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    647582d View commit details
    Browse the repository at this point in the history

  4. Catch remaining unfixed import path.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    26f3e61 View commit details
    Browse the repository at this point in the history

  5. Fix easier mypy annotations in datatree.py and test_datatree.py.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    5e575d7 View commit details
    Browse the repository at this point in the history

  6. Straggling mypy change in datatree.py.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6b7a15f View commit details
    Browse the repository at this point in the history

  7. datatree.py comment clean-up.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    738bf28 View commit details
    Browse the repository at this point in the history

  8. More mypy corrections in datatree.py and test_datatree.py.

    @owenlittlejohns @flamingbear
    owenlittlejohns authored and flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    6eaa021 View commit details
    Browse the repository at this point in the history

  9. Removes unnecessary dict wrapper.

    @flamingbear
    flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    0397e67 View commit details
    Browse the repository at this point in the history

  10. DAS-2062: renames as_array -> to_dataarray

    @flamingbear
    flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    c45c56a View commit details
    Browse the repository at this point in the history

  11. DAS-2062: Updates doc string for Datatree.to_zarr 

    Accurately reflects the default value now.
    @flamingbear
    flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    b333b1d View commit details
    Browse the repository at this point in the history

  12. DAS-2062: reverts what-new.rst 

    for "breaking changes that aren't breaking yet but will be, but only relevant
for previous users of another package"
    @flamingbear
    flamingbear committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    34e00bd View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @flamingbear
    flamingbear committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    c171470 View commit details
    Browse the repository at this point in the history

  2. DAS-2062: clarify wording in comment.

    @flamingbear
    flamingbear committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    a0d3702 View commit details
    Browse the repository at this point in the history

  3. Change Datatree.to_dataarray to call correctly 

    We updated the name but not the function.
    @flamingbear
    flamingbear committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    869103b View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @flamingbear
    flamingbear committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    379bc5c View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Clarify DataTree's names are still strings now. 

    DAS-2062
    @flamingbear
    flamingbear committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    12590fb View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @dcherian
    dcherian committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8c3ba13 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @flamingbear
    flamingbear committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    5cc7c41 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. DAS-2062: Cast k explicitly to str for typing. 

    So this is where we are moving forward with the assumption that DataTree nodes
are alway named with a string. In this section of `update` even though we know
the key is a str, mypy refuses.

I chose explicit recast over mypy ignores, tell me why that's wrong?
    @flamingbear
    flamingbear committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4a53979 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Ignore mypy errors for DataTree.ds assignment.

    @owenlittlejohns
    owenlittlejohns committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ffa5f71 View commit details
    Browse the repository at this point in the history

  2. Fix DataTree.update type hint.

    @owenlittlejohns
    owenlittlejohns committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    881af78 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Final mypy issue - ignore DataTree.get override.

    @owenlittlejohns
    owenlittlejohns committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3fc4796 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Update contributors in whats-new.rst

    @owenlittlejohns
    owenlittlejohns committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    14b5c02 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @owenlittlejohns
    owenlittlejohns committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3aaf837 View commit details
    Browse the repository at this point in the history

  3. Fix GitHub handle.

    @owenlittlejohns
    owenlittlejohns committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ce68416 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge branch 'main' into DAS-2062-migrate-datatree-module-pr

    @flamingbear
    flamingbear committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    0ae54cb View commit details
    Browse the repository at this point in the history