Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement setitem syntax for .oindex and .vindex properties #8845

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Implement setitem syntax for .oindex and .vindex properties #8845

merged 8 commits into from
Mar 19, 2024

Commits on Mar 16, 2024

  1. Implement setitem syntax for .oindex and .vindex properties

    @andersy005
    andersy005 committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    b47d1ab View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
    @andersy005 @dcherian
    andersy005 and dcherian committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    3413289 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into expand-use-of-oindex-vindex-in-setitem

    @andersy005
    andersy005 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e3bbb58 View commit details
    Browse the repository at this point in the history

  3. use getter and setter properties instead of func_get and func_set met… 

    …hods
    @andersy005
    andersy005 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2b0888c View commit details
    Browse the repository at this point in the history

  4. delete unnecessary _indexing_array_and_key method

    @andersy005
    andersy005 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    bd26644 View commit details
    Browse the repository at this point in the history

  5. Add tests for IndexCallable class

    @andersy005
    andersy005 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    d015df4 View commit details
    Browse the repository at this point in the history

  6. fix bug/unnecessary code introduced in pydata#8790

    @andersy005
    andersy005 committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8d58b6f View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. add unit tests

    @andersy005
    andersy005 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c4547d3 View commit details
    Browse the repository at this point in the history