Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing to some functions in indexing.py #8922

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add typing to some functions in indexing.py #8922

merged 2 commits into from
Apr 10, 2024

Conversation

Illviljan
Copy link
Contributor

@Illviljan Illviljan commented Apr 8, 2024 •
edited

A drive-by PR as I was trying to figure out how these functions works.

max-sixty
max-sixty approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@Illviljan Illviljan marked this pull request as ready for review April 9, 2024 15:45
@dcherian dcherian merged commit a07e16c into pydata:main Apr 10, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Illviljan @max-sixty @dcherian