fixes for the pint tests
#8983
Open
fixes for the pint tests
#8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
reviewed
Apr 29, 2024
| @@ -58,6 +58,8 @@ python -m pip install \ | |||
| --upgrade \ | |||
| --no-build-isolation \ | |||
| git+https://github.com/pydata/bottleneck | |||
| # manually install pint deps. These will be pulled in by the next released version, but for now we have to install them (since we use `--no-deps` pip will not pull them in the install). | |||
| python -m pip install --upgrade 'flexcache>=0.3' 'flexparser>=0.3' 'appdirs>=1.4.4' typing_extensions | |||
There was a problem hiding this comment.
No big change but possibly this could just be python -m pip install --upgrade pint, and that will do deps?
There was a problem hiding this comment.
that would work if the released version had the same dependencies as the upstream-dev version. Unfortunately, all of these (except typing_extensions) have been added since the last release.
Another option would be to add python -m pip install --upgrade git+https://github.com/hgrecco/pint (i.e. no --no-deps for pint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of the deprecated
numpy.core._exceptions.UFuncError(and multiplication as a way to attach units), and makes sure we run thepinttests in the upstream-dev CI again.