Addressed review comments

* type hint updated for find_group_by_id
pydcs · Jan 12, 2024 · 5dccfb1 · 5dccfb1
1 parent db08c70
commit 5dccfb1
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/dcs/country.py b/dcs/country.py
@@ -3,7 +3,7 @@
 from dcs.helicopters import HelicopterType
 from dcs.planes import PlaneType
 from dcs.unitgroup import VehicleGroup, ShipGroup, PlaneGroup, StaticGroup, HelicopterGroup, FlyingGroup, Group
-from typing import List, Dict, Optional, Set, Type
+from typing import List, Dict, Optional, Set, Type, Sequence
 
 
 def find_exact(group_name, find_name):
@@ -82,11 +82,11 @@ def find_group(self, group_name, search="exact"):
         return None
 
     def find_group_by_id(self, group_id: int) -> Optional[Group]:
-        groups: List = [self.vehicle_group,
-                        self.ship_group,
-                        self.plane_group,
-                        self.helicopter_group,
-                        self.static_group]
+        groups: List[Sequence[Group]] = [self.vehicle_group,
+                                         self.ship_group,
+                                         self.plane_group,
+                                         self.helicopter_group,
+                                         self.static_group]
         for search_group in groups:
             for group in search_group:
                 if group.id == group_id: