Many lua parser fixes. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently semicolons and commas are both allowed as element separators in tables. https://www.lua.org/cgi-bin/demo accepts it, and some liveries do that.
Previously the parser would assume any unknown variable was a new decl, but if it wasn't the parser gave an rather unhelpful error. This improves the error message by default, and also gives the caller a way to fill undefined variables. The undefined variable is only a problem if that caller is going to read that value, and that's not always the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not done yet. This fixes a handful of bugs (and adds missing features) necessary for parsing liveries lua descriptions.