Export additional unit property info. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
DanAlbert
force-pushed
the
more-property-data
branch
from
de0de4c
to
0d2af9b
Compare
There's a lot of additional data available in the lua database that informs any callers how to implement the UI. Expose that in the unit type as well. I've added this as a new API surface rather than extending the data in the old API which is only queryable via reflection. The old API is good for hard-coded mission generators that want to set properties explicitly, but for anyone trying to create a UI for setting these (such as Liberation does), it's preferable to have access without reflection.
DanAlbert
force-pushed
the
more-property-data
branch
from
0d2af9b
to
68f5e75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of additional data available in the lua database that informs any callers how to implement the UI. Expose that in the unit type as well.
I've added this as a new API surface rather than extending the data in the old API which is only queryable via reflection. The old API is good for hard-coded mission generators that want to set properties explicitly, but for anyone trying to create a UI for setting these (such as Liberation does), it's preferable to have access without reflection.