Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loads and saves requiredModules #346

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Loads and saves requiredModules #346

merged 8 commits into from
Dec 21, 2023

Conversation

332fg-raven
Copy link
Contributor

Loads and saves requiredModules section.

DanAlbert
DanAlbert requested changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@DanAlbert DanAlbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor review notes, but since the checks didn't pass anyways, might as well fix them at the same time.

Otherwise LGTM, and thanks!

dcs/mission.py Outdated Show resolved Hide resolved
tests/test_mission.py Outdated Show resolved Hide resolved
@332fg-raven
Addressed review comments
3508c13 
* test_smoke_required_modules now asserts content
  of required_modules
@DanAlbert DanAlbert merged commit a371de7 into pydcs:master Dec 21, 2023
4 checks passed
@332fg-raven 332fg-raven deleted the feature/support-for-required-modules branch January 10, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanAlbert DanAlbert Awaiting requested review from DanAlbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@332fg-raven @DanAlbert