Make it possible to deserialize missions containing RecoveryTanker tasks #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magwo
force-pushed
the
fix-recovery-tanker
branch
from
6d1f0d8
to
c8fa7be
Compare
magwo
force-pushed
the
fix-recovery-tanker
branch
from
c8fa7be
to
ae85851
Compare
|
Not sure if we need None handling of the lastWaypoint thing. |
|
Thanks for catching the missing entry. |
DanAlbert
reviewed
Feb 9, 2024
| @@ -739,7 +739,7 @@ def __init__(self): | |||
| class RecoveryTanker(Task): | |||
| Id = "RecoveryTanker" | |||
|
|
|||
| def __init__(self, groupId: int, speed: float, altitude: float, lastWaypoint: Optional[int]): | |||
| def __init__(self, groupId=None, speed=600, altitude=4000, lastWaypoint: Optional[int] = None): | |||
There was a problem hiding this comment.
Don't delete the type annotations. You've changed this signature from float to int here.
Isn't that because it's missing a (making the optional last waypoint argument optional makes sense, of course) |
|
Good points, will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appears to have been a mistake when the RecoveryTanker task was added but not added to the tasks map.
Also missing default parameters which I think is preventing deserialization.