Fix for setting password for Unit Groups #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
332fg-raven
commented
Feb 13, 2024
332fg-raven
commented
- Password is not base64 encoded, but base64URL encoded. Missed that in the initial read.
332fg-raven
force-pushed
the
feature/fix-for-UnitGroup-password
branch
from
52c9577
to
faeb6ee
Compare
332fg-raven
force-pushed
the
feature/fix-for-UnitGroup-password
branch
from
faeb6ee
to
b432535
Compare
|
@rp- or @DanAlbert - can you please merge this. If there's anything wrong, let me know so I can address it. Thank you! |
rp-
reviewed
Apr 12, 2024
* Password is not base64 encoded, but it's base64URL encoded.
* Passwords can be set for units as well as ground control roles therefore it's more suitable to have password_hash implemented as a utility.
332fg-raven
force-pushed
the
feature/fix-for-UnitGroup-password
branch
from
b432535
to
ed04673
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.