Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply deid recipe actions to private DICOM tags #118

Closed
wetzelj opened this issue Mar 6, 2020 · 2 comments
Closed

Apply deid recipe actions to private DICOM tags #118

wetzelj opened this issue Mar 6, 2020 · 2 comments

Comments

@wetzelj
Copy link
Contributor

wetzelj commented Mar 6, 2020

As discussed within PR #112 (comments), expand the list of fields evaluated to include private tags. This should enable recipe actions to be defined and applied to private tags in the same manner as they can be applied to public tags.

Since private tags do not have an assigned Name, these will have to be identified using the DICOM tag numbers.

@vsoch
Copy link
Member

vsoch commented Mar 6, 2020

Yes! And we'll also need to better account for types. Most private tags can be indexed with their tag object, but when it comes to assigning some new value, we can't just throw in a string like we would for something like PatientID. This is similar to the function assignment issue, but more common for tags because it's never a simple string, but usually another Data Element.

@vsoch
Copy link
Member

vsoch commented Apr 29, 2020

This is definitely done! Please open a new issue if anything comes up.

@vsoch vsoch closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants