Adding ability to specify a filter with REMOVE

[vsoch]

Currently, REMOVE can handle a func:, however since we are returning a boolean, we can easily also support the already existing filters that return a boolean (contains, equals, etc.) This
change will allow for those filters. This will address #123, pinging @wetzelj

Signed-off-by: vsoch vsochat@stanford.edu

Questions that require more discussion or to be addressed in future development:

[wetzelj]

I'm having a hard time figuring out the purpose of the missing, present, and empty expanders in this situation - and what the expected results should be. In my testing REMOVE ALL empty removed all tags. I was left with a header that contained only those items that I added back in after performing the REMOVE ALL empty.

My expectation would be that REMOVE ALL empty would remove tags that contained empty values. I don't quite understand how present or missing would apply to values.

[vsoch]

Yeah I was just thinking about this too - I was grabbing the filters from the list already derived, but I don't think those particular filters make sense. I'm going to remove them.

[vsoch]

oops didn't mean to close it.

[wetzelj]

Looks good!

[vsoch]

https://pypi.org/project/deid/0.1.41/

[vsoch]

@wetzelj let me think about your comment:

Regarding the plan forward... #118 is really one of the higher priority issues from our standpoint, but if you think that #119 should be done first, that's okay too.

In that adding private tags will mean parsing over the tag objects (which reveal data elements) I'm actually thinking that these two separate issues need to be addressed at the same time - we will be able to easily loop over private tags if the get/set is available. I can't promise starting on this today, but soon!

[wetzelj]

No problem! I appreciate all of your work on this!