Double definiton of write_snomed_mapping()

[DimitriPapadopoulos]

Describe the bug

Function write_snomed_mapping() is defined twice:

• pydicom/source/generate_cids/generate_concept_dicts.py

  Lines 249 to 270 in f807e71

  	def write_snomed_mapping(snomed_codes):
  	with open("_snomed_dict.py", 'w', encoding="UTF8") as f_concepts:
  	lines = (DOC_LINES +
  	['# Dict with scheme designator keys; value format is:\n',
  	'# {concept_id1: snomed_id1, concept_id2: ...}\n',
  	'# or\n',
  	'# {snomed_id1: concept_id1, snomed_id2: ...}\n',
  	'\n',
  	]
  	)
  	f_concepts.writelines(lines)
  	f_concepts.write("mapping = {}\n") # start with empty dict
  	f_concepts.write("\nmapping['{}'] = {{\n".format('SCT'))
  	for sct, srt, meaning in snomed_codes:
  	f_concepts.write(" '{}': '{}',\n".format(sct, srt))
  	f_concepts.write("}\n")
  	f_concepts.write("\nmapping['{}'] = {{\n".format('SRT'))
  	for sct, srt, meaning in snomed_codes:
  	f_concepts.write(" '{}': '{}',\n".format(srt, sct))
  	f_concepts.write("}")

• pydicom/source/generate_cids/generate_concept_dicts.py

  Lines 311 to 332 in f807e71

  	def write_snomed_mapping(snomed_codes):
  	with open("_snomed_dict.py", 'w', encoding="UTF8") as f_concepts:
  	lines = (DOC_LINES +
  	['# Dict with scheme designator keys; value format is:\n',
  	'# {concept_id1: snomed_id1, concept_id2: ...}\n',
  	'# or\n',
  	'# {snomed_id1: concept_id1, snomed_id2: ...}\n',
  	'\n',
  	]
  	)
  	f_concepts.writelines(lines)
  	f_concepts.write("mapping = {}\n") # start with empty dict
  	f_concepts.write("\nmapping['{}'] = {{\n".format('SCT'))
  	for sct, srt, meaning in snomed_codes:
  	f_concepts.write(" '{}': '{}',\n".format(sct, srt))
  	f_concepts.write("}\n")
  	f_concepts.write("\nmapping['{}'] = {{\n".format('SRT'))
  	for sct, srt, meaning in snomed_codes:
  	f_concepts.write(" '{}': '{}',\n".format(srt, sct))
  	f_concepts.write("}")

Expected behavior

Unless I'm missing the reason, a single definition should be enough. Hard to tell which one to keep, both have been introduced in #824.

[DimitriPapadopoulos]

Fixing this will fix this LGTM warning:
https://lgtm.com/projects/g/pydicom/pydicom/snapshot/b3ab7ceed7ea4b8b79e6f72248096c97dd527328/files/source/generate_cids/generate_concept_dicts.py#xe1a70f817f3b0bb8:1

[scaramallion]

Closed by #1493