[MRG] LGTM warnings: Variable defined multiple times #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
changed the title
DimitriPapadopoulos
force-pushed
the
variable_defined_multiple_times
branch
from
903e024
to
aa3b92a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1493 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 66 66
Lines 10183 10183
=======================================
Hits 9921 9921
Misses 262 262 Continue to review full report at Codecov.
|
| @@ -210,67 +210,6 @@ def get_table_d1(): | |||
|
|
|||
|
|
|||
| def write_concepts(concepts, cid_concepts, cid_lists, name_for_cid): | |||
| lines = (DOC_LINES + | |||
There was a problem hiding this comment.
Better use this version, as it uses DOC_LINES for the duplicated part.
There was a problem hiding this comment.
Ah, that's right. Fixed now.
DimitriPapadopoulos
force-pushed
the
variable_defined_multiple_times
branch
from
aa3b92a
to
4fe7c44
Compare
This assignment to 'write_concepts' is unnecessary as it is redefined here before this value is used. This assignment to 'write_snomed_mapping' is unnecessary as it is redefined here before this value is used. https://lgtm.com/rules/1800095/
DimitriPapadopoulos
force-pushed
the
variable_defined_multiple_times
branch
from
4fe7c44
to
44f97c5
Compare
mrbean-bremen
approved these changes
Aug 31, 2021
This was referenced Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
Fix LGTM warnings:
https://lgtm.com/projects/g/pydicom/pydicom/snapshot/283a1a1994d3d01b4d1e1fb3959c4de35c3240a8/files/source/generate_cids/generate_concept_dicts.py#x9b38b497e036fd51:1
https://lgtm.com/projects/g/pydicom/pydicom/snapshot/283a1a1994d3d01b4d1e1fb3959c4de35c3240a8/files/source/generate_cids/generate_concept_dicts.py#xe1a70f817f3b0bb8:1
I have kept the last definitions of the two functions - the definitions currently used.
Tasks
doc/_build/html/index.html)