Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Do not use pytest.warns(None) #1623

Merged
merged 1 commit into from Mar 29, 2022

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Mar 29, 2022

I did not add release notes, I think they are not needed for this.

Tasks

  • Fix or feature added
  • Code typed and mypy shows no errors

- avoids deprecation warnings from pytest
- fixes pydicom#1621
@mrbean-bremen mrbean-bremen changed the title Do not use pytest.warns(None) [MRG] Do not use pytest.warns(None) Mar 29, 2022
@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1623 (27e58a6) into master (728c8ac) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1623      +/-   ##
==========================================
+ Coverage   97.57%   97.67%   +0.10%     
==========================================
  Files          66       66              
  Lines       10660    10660              
==========================================
+ Hits        10401    10412      +11     
+ Misses        259      248      -11     
Impacted Files Coverage Δ
pydicom/valuerep.py 99.53% <0.00%> (+0.15%) ⬆️
pydicom/filewriter.py 98.06% <0.00%> (+0.24%) ⬆️
pydicom/filereader.py 94.62% <0.00%> (+0.25%) ⬆️
pydicom/uid.py 100.00% <0.00%> (+1.09%) ⬆️
pydicom/filebase.py 99.19% <0.00%> (+1.61%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@scaramallion scaramallion merged commit 37c0f95 into pydicom:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deprecated pytest.warns(None)
2 participants