[MRG+1] Fix length validation of DS values #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1633 +/- ##
==========================================
+ Coverage 97.57% 97.67% +0.10%
==========================================
Files 66 66
Lines 10666 10666
==========================================
+ Hits 10407 10418 +11
+ Misses 259 248 -11
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
mrbean-bremen
changed the title
darcymason
approved these changes
Apr 14, 2022
darcymason
changed the title
- use str() instead of repr() for validation - this uses the original string if available - fixes pydicom#1632
mrbean-bremen
force-pushed
the
dsfloat-check
branch
from
77fd9bd
to
9c617b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the original string if available
Tasks