[MRG] Skip jpeg-ls tests for Python 3.11 #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1708 +/- ##
==========================================
+ Coverage 97.58% 97.60% +0.01%
==========================================
Files 66 66
Lines 10744 10744
==========================================
+ Hits 10485 10487 +2
+ Misses 259 257 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
- CharPyLS does not compile under Linux/MacOS - also add 3.11 builds for PR builds
mrbean-bremen
force-pushed
the
skip_ls_for_3.11
branch
from
28324a3
to
a0d6215
Compare
mrbean-bremen
commented
Oct 5, 2022
.github/workflows/pr-pytest.yml
Outdated
| @@ -90,7 +90,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest, windows-latest, macos-latest] | |||
| python-version: ['3.10'] | |||
| python-version: ['3.10', '3.11-dev'] | |||
There was a problem hiding this comment.
I just added this temporarily to be able to check if the condition works in the PR - will remove it afterwards.
- pylibjpeg-openjpeg and pylibjpeg-libjpeg also fail to build
mrbean-bremen
force-pushed
the
skip_ls_for_3.11
branch
from
78adfd7
to
cad1b93
Compare
- have been there only for testing the condition
mrbean-bremen
changed the title
darcymason
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seems to have forgotten to add 3.11 builds to the PR builds, so this was not visible there.
Tasks