[MRG] Pytest deprecations #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup and teardown deprecated in pytest 7.2, rename to setup_method and teardown_method
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.01%
==========================================
Files 66 66
Lines 10769 10769
==========================================
+ Hits 10510 10512 +2
+ Misses 259 257 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mrbean-bremen
approved these changes
Nov 15, 2022
doc/release_notes/v2.4.0.rst
Outdated
| @@ -4,6 +4,8 @@ Version 2.4.0 | |||
| Changes | |||
| ------- | |||
| * Removed support for Python 3.6 (EOL since December 2021) | |||
| * In test suite, renamed 'setup' and 'teardown' methods, | |||
There was a problem hiding this comment.
I would put this under something like 'infrastructure' if at all, as this is not a change in pydicom, and the users are probably not interested in it.
There was a problem hiding this comment.
Yeah, I was wondering about that too. Perhaps we need a 'For pydicom developers' or 'Pydicom internals' section. I'll update that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest 7.2 is now giving a large number of warnings about deprecated
setupandteardownmethods (which they say arenosetests and they will stop support fornosein future).Their recommendation is to simply search/replace those names to
setup_methodandteardown_method, which is what this PR does.doc/_build/html/index.html)