[MRG] [DOC] File-set tutorial styling suggestions #1764
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1764 +/- ##
==========================================
+ Coverage 97.41% 97.43% +0.01%
==========================================
Files 66 66
Lines 10837 10837
==========================================
+ Hits 10557 10559 +2
+ Misses 280 278 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
doc/tutorials/filesets.rst
Outdated
| @@ -262,9 +262,9 @@ This includes changes such as: | |||
|
|
|||
| * Adding SOP instances using the :meth:`FileSet.add() | |||
| <pydicom.fileset.FileSet.add>` or :meth:`FileSet.add_custom() | |||
| <pydicom.fileset.FileSet.add_custom>` methods | |||
| <pydicom.fileset.FileSet.add_custom>` methods. | |||
There was a problem hiding this comment.
I think no period is needed in such lists, if the list item is not a sentence (I'm not a native speaker, so I may be wrong).
There was a problem hiding this comment.
I tend to agree, in bullet or point form lists usually a period is not needed
There was a problem hiding this comment.
@mrbean-bremen @darcymason that's correct (according to the internet); however, the style should be consistent within a single list (ref). I added these periods here to conform with the next two items.
There was a problem hiding this comment.
In this case I suggest to remove the periods in these two items, otherwise this just looks wrong to me.
Minor styling suggestions to the DICOM File-sets and DICOMDIR tutorial.