Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions: Upgrade to Python v3.11 production release #1777

Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 24, 2023

Describe the changes

The related issue or a description of the bug or feature that this PR addresses.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1777 (3453c7e) into master (2709ff6) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1777      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%     
==========================================
  Files          66       66              
  Lines       10839    10839              
==========================================
+ Hits        10559    10561       +2     
+ Misses        280      278       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pytest ${{ matrix.pytest-args }} pydicom/tests/test_pillow_pixel_data.py
python -m pip uninstall -y pillow

- name: Install and test jpeg_ls
if: ${{ matrix.python-version != '3.11-dev' }}
if: ${{ matrix.python-version != '3.12-dev' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this in preparation for 3.12 builds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, one more alpha release before the beta cycle starts…

https://peps.python.org/pep-0693/#schedule

@darcymason darcymason merged commit 3ec2799 into pydicom:master Mar 25, 2023
26 checks passed
@cclauss cclauss deleted the ci-upgrade-to-py3.11-production-release branch March 25, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants