Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Exclude CharPyLS for Python 3.11 #1791

Merged
merged 1 commit into from Apr 22, 2023

Conversation

mrbean-bremen
Copy link
Member

@mrbean-bremen mrbean-bremen commented Apr 22, 2023

For the time being, just exclude JPEG-LS builds for Python > 3.10 and add a note in the transfer syntax table.

Tasks

  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1791 (a7cd305) into master (27ef8f4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1791      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%     
==========================================
  Files          66       66              
  Lines       10839    10839              
==========================================
+ Hits        10559    10561       +2     
+ Misses        280      278       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrbean-bremen mrbean-bremen marked this pull request as ready for review April 22, 2023 20:42
@mrbean-bremen mrbean-bremen changed the title Exclude CharPyLS for Python 3.11 [MRG] Exclude CharPyLS for Python 3.11 Apr 22, 2023
@darcymason darcymason merged commit 6a64393 into pydicom:master Apr 22, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants