New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Use CharPyLS fork with newer cython version #1794
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
=======================================
Coverage 97.41% 97.41%
=======================================
Files 66 66
Lines 10839 10839
=======================================
Hits 10559 10559
Misses 280 280
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This seems to work, but I want to first decide about the PyPi package and adapt the documentation accordingly before merging. |
@darcymason - there is a problem with the doc build, so I cannot view the preview. It looks like you are working on the doc build anyway, so I'm just ignoring this. |
I haven't turned CircleCI off yet, so I thought it should still be there, but I haven't checked. |
CircleCI is building, but it fails with:
This seems not to be related to my changes. I didn't look into the cause, because you are working on the documentation generation anyway. |
Oh yeah, I actually fixed that in the other PR (#1793) ... you could just borrow the additional |
- should fix Python 3.11 builds - change Python version for PR tests to 3.11 - fix syntax in conf.py (taken from pydicom#1793) - fixes pydicom#1788
Ok, I adapted the name and borrowed your fix for |
Ping @darcymason |
Sorry, lost track of this one. Merging now. |
Thank you! |
Note that I left the note about JPEG-LS not available for Python 3.11, because I first want to make sure that it works, and then either advice to install from source, or add an own pypi package for our fork (which I would prefer).
Tasks
doc/_build/html/index.html
)