Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codify rel path #1867

Merged
merged 8 commits into from
Aug 15, 2023
Merged

Fix codify rel path #1867

merged 8 commits into from
Aug 15, 2023

Conversation

darcymason
Copy link
Member

For #1865

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1867 (f0934ef) into main (34c68f9) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1867      +/-   ##
==========================================
- Coverage   97.58%   97.57%   -0.01%     
==========================================
  Files          64       63       -1     
  Lines       10760    10741      -19     
==========================================
- Hits        10500    10481      -19     
  Misses        260      260              
Files Changed Coverage Δ
src/pydicom/dataelem.py 98.38% <ø> (-0.02%) ⬇️
src/pydicom/pixel_data_handlers/rle_handler.py 100.00% <ø> (ø)
src/pydicom/cli/main.py 95.55% <100.00%> (+0.10%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/pydicom/cli/main.py Outdated Show resolved Hide resolved
@darcymason darcymason merged commit 7d1ea5d into main Aug 15, 2023
9 checks passed
@darcymason darcymason deleted the fix-codify-rel-path branch August 15, 2023 19:43
darcymason added a commit that referenced this pull request Aug 15, 2023
* cherry-picked from main branch of 3.0 dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants