Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Allow A-RELEASE instead of A-ABORT on network timeout #725

Merged
merged 3 commits into from
Dec 27, 2021

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Dec 27, 2021

Reference issue

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy

@codecov
Copy link

codecov bot commented Dec 27, 2021

Codecov Report

Merging #725 (ddeb640) into master (7a0c87b) will not change coverage.
The diff coverage is 100.00%.

❗ Current head ddeb640 differs from pull request most recent head dab1766. Consider uploading reports for the commit dab1766 to get more accurate results

@@            Coverage Diff            @@
##            master      #725   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8642      8647    +5     
=========================================
+ Hits          8642      8647    +5     
Impacted Files Coverage Δ
pynetdicom/dul.py 100.00% <ø> (ø)
pynetdicom/association.py 100.00% <100.00%> (ø)

@scaramallion scaramallion changed the title [WIP] Allow A-RELEASE instead of A-ABORT on network timeout [MRG] Allow A-RELEASE instead of A-ABORT on network timeout Dec 27, 2021
@scaramallion scaramallion merged commit 313b364 into pydicom:master Dec 27, 2021
@scaramallion scaramallion deleted the dev-timeout branch December 27, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release instead of Abort when network_timeout expires
1 participant