Skip to content
This repository has been archived by the owner on Nov 25, 2020. It is now read-only.

Update class.AJXP_Sabre_Collection.php #861

Closed
wants to merge 1 commit into from

Conversation

raiatea
Copy link
Contributor

@raiatea raiatea commented Mar 16, 2015

symptom: $this->repository->getOption("SHOW_HIDDEN_FILES") always return empty string
reason: SHOW_HIDDEN_FILES is a plugin option
solution: $this->getAccessDriver()->getFilteredOption("SHOW_HIDDEN_FILES").
getFilteredOption need to be public in core\classes\class.AJXP_Plugin.php(138)

symptom: $this->repository->getOption("SHOW_HIDDEN_FILES") always return empty string
reason: SHOW_HIDDEN_FILES is a plugin option
solution: $this->getAccessDriver()->getFilteredOption("SHOW_HIDDEN_FILES").
getFilteredOption need to be public in core\classes\class.AJXP_Plugin.php(138)
@cdujeu
Copy link
Member

cdujeu commented Mar 16, 2015

@raiatea could you kindly avoid submitting one PR per file, when they are about the same subject? Your next PR and that one should have been only one, including the two commits.
That said, not very fan on changing methods visibility on core object like Plugin... Will have a look at that :-)

@raiatea
Copy link
Contributor Author

raiatea commented Mar 16, 2015 via email

@cdujeu
Copy link
Member

cdujeu commented Mar 16, 2015

ha ha, if it was my proposal it's different :-)
Could you point me to the existing forum thread?
Charles

@raiatea
Copy link
Contributor Author

raiatea commented Mar 16, 2015 via email

@cdujeu cdujeu closed this in 481e176 Mar 20, 2015
@raiatea raiatea deleted the patch-2 branch March 20, 2015 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants