Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move primary key generation for mssql backend after completely filling a table. #190

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

windiana42
Copy link
Member

@windiana42 windiana42 commented Apr 26, 2024

For mssql backend, moved string type changes for index columns after creation of empty table and before filling it. We were not sure at first which one would be faster.

Checklist

  • Added a docs/source/changelog.md entry
  • Added/updated documentation in docs/source/
  • Added/updated examples in docs/source/examples.md

@windiana42 windiana42 marked this pull request as ready for review April 26, 2024 13:38
@windiana42 windiana42 requested a review from a team as a code owner April 26, 2024 13:38
@windiana42 windiana42 merged commit d78675a into main Apr 26, 2024
24 checks passed
@windiana42 windiana42 deleted the late_primary_key branch April 26, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant