Skip to content

Commit

Permalink
minor wording changes.
Browse files Browse the repository at this point in the history
  • Loading branch information
schettino72 committed May 12, 2019
1 parent 449008e commit ee87c21
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Changes
- Add configuration `DOIT_CONFIG` `action_string_formatting` to control command action formatter.
- Fix `result_dep`, use result **after** its execution
- Fix #286: Support `functools.partial` on tasks' dict metadata `task.title`
- Fix #285: `clean` command, remove targets in reverse DFS order
- Fix #285: `clean` command, remove targets in reverse lexical order


0.31.1 (*2018-03-18*)
Expand Down
4 changes: 2 additions & 2 deletions doc/cmd_other.rst
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ is empty, otherwise it will display a warning message.
.. note::

The targets' removal order will be the reverse of their lexical ordering.
This ensures that the directory structure formed by the targets is correctly
removed irrespective of their order in the ``targets`` array.
This ensures that files in a directory are removed before the directory
irrespective of their order in the ``targets`` array.

The *clean* attribute can be a list of actions. An action could be a
string with a shell command or a tuple with a python callable.
Expand Down
1 change: 1 addition & 0 deletions doc/dictionary.txt
Original file line number Diff line number Diff line change
Expand Up @@ -463,3 +463,4 @@ x'
xxx
xyz
zsh
functools
4 changes: 2 additions & 2 deletions doc/tutorial_1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ Sub-tasks (items of task group) by default are not reported by the ``list`` comm
Note the task's name is composed of the task's group name (aka ``basename``)
followed by a colon `:` and the ``name`` specified as a parameter when ``yield``ing.
followed by a colon `:` and the ``name`` specified as a parameter when ``yield``.

From the command line, a single task can be executed like this:

Expand Down Expand Up @@ -646,7 +646,7 @@ printing imports
================

Getting rid of intermediate computation files (like ``requests.models.deps``) was nice...
but sometimes it is usefull to be able to quickly list the direct imports from a module.
but sometimes it is useful to be able to quickly list the direct imports from a module.

Let's create another task that just prints its output in the terminal.

Expand Down
2 changes: 1 addition & 1 deletion tests/test_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ def test_keep_non_empty_dirs(self, tmpdir):
assert expected == os.path.exists(filename)
assert os.path.exists(tmpdir['dir'])

def test_clean_in_reverse_lexical_order(self, tmpdir):
def test_clean_any_order(self, tmpdir):
# Remove targets in reverse lexical order so that subdirectories' order
# in the targets array is irrelevant
targets = tmpdir['files'] + [tmpdir['dir'], tmpdir['subdir']]
Expand Down

0 comments on commit ee87c21

Please sign in to comment.