Fix race condition in doit.tools.create_folder #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create_folder` had a race condition: if many tasks try to create the same folder then it is possible that between checking directory existence and actual creation of the directory in the next line another task will create that directory. Since [python 3.2](https://docs.python.org/3.4/library/os.html#os.makedirs) `os.makedirs` has nice `exist_ok` argument that will do the same thing but without such problems.
|
Dropping python 2 is great 😁 I am extremely busy these days. I will merge as soon as I get some extra time, yeah i could just click a button but I dont like github merging stuff for me... |
|
Of course! Do it at any time 😉 |
|
merged: 169a1df I amended the commit to add an entry on CHANGES. so github thinks this was not merged... thanks 😄 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
While making possible to run build of my project concurrently with
-n NUMBERoption I discovered thatcreate_folderhas a race condition: if many tasks try to create the same folder then it is possible that between checking directory existence and actual creation of the directory in the next line another task will create that directory.Since python 3.2
os.makedirshas niceexist_okargument that will do the same thing but without such problems.