Fix auto command on OS X #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 23f1749 on smutch:mac-auto-fix into * on pydoit:master*. |
|
thanks. I will merge this soon. probably this week. Please add your name to the authors file 😄 |
|
Changes Unknown when pulling 0847ad3 on smutch:mac-auto-fix into * on pydoit:master*. |
|
Great! Glad its useful. Thanks for a great piece of software. I only started using a week ago, but it is already proving really useful for my research! |
|
thanks |
|
When is the next release planned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the fsevents observer on the main thread, allowing the auto command to pickup file changes and run the appropriate tasks. This may address #49 (and possibly #101) by fixing the current implementation without moving to using Watchdog.
The filewatcher test fails on OS X both before and after this patch, but testing the auto command manually after applying the patch seems to show that the auto command works. I am unaware if there are any unintended consequences of running the observer on the main thread though as I have no previous experience with fsevents.