Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional SQLite import #154

Merged
merged 3 commits into from
Oct 25, 2016

Conversation

multimeric
Copy link
Contributor

Only imports the SQLite module as required, as documented in doit issue 153.

This is useful in cases where python has been compiled without sqlite support but users want to use a different backend (e.g. json)

Includes a small unit test for this requirement.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.79% when pulling 97b540b on TMiguelT:conditional-sqlite-import into 4260fc0 on pydoit:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.79% when pulling 2e55dca on TMiguelT:conditional-sqlite-import into 4260fc0 on pydoit:master.

@multimeric
Copy link
Contributor Author

It's not building on Windows and I can't for the life of me work out why

@schettino72
Copy link
Member

The failure is not in your test... dont bother about it.
This test used to work but started to fail, not sure a change in a library or appveyor.

Thanks. Please add your name on AUTHORS file 😄

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.79% when pulling f716c89 on TMiguelT:conditional-sqlite-import into 4260fc0 on pydoit:master.

@multimeric
Copy link
Contributor Author

Done!

@multimeric
Copy link
Contributor Author

Any chance of merging this?

@schettino72
Copy link
Member

sorry. i will do it this week.

@schettino72 schettino72 merged commit f716c89 into pydoit:master Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants