Fix passing environment variables to CmdAction #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exercises issue pydoit#171.
This fixes issue pydoit#171.
The "TestCmdAction.test_env" test contained a problem: the current environment should be explicitly copied, and amended with the extra environment variables to set, instead of passing in an otherwise empty environment. This caused the tests to (rightly) fail on Windows CI hosts.
|
thanks. please give me sometime to merge this as I will not be available next few days. |
|
Sure, no rush. Thanks for your time and efforts in maintaining pydoit :-) |
schettino72
reviewed
May 29, 2017
| @@ -17,6 +23,12 @@ | |||
| sys.stdout.write("out ouch") | |||
| sys.stderr.write("err output on failure") | |||
| sys.exit(11) | |||
| # check env | |||
| if len(sys.argv) == 3 and sys.argv[1]=='check' and sys.argv[2]=='env': | |||
| if os.environ.get('GELKIPWDUZLOVSXE') == '1': | |||
There was a problem hiding this comment.
so what GELKIPWDUZLOVSXE means? 😁
There was a problem hiding this comment.
Just a random string really. Although I'm sure we can come up with a backronym 😁
|
thanks. merged. Are you on AUTHORS file? if not please add your name there. |
|
Thanks, but such a tiny pull request is something I wouldn't like to call 'authoring' ;-) Once I make a more significant contribution, I'd be happy to add myself to the list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #171. It also includes a small test for passing environment variables to subprocesses.