-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use load_ipython_extension to register doit magic functions #192
Conversation
Update the source and documentation for the IPython tool extension. The update simplifies loading by using the load_ipython_extension namespace instead of register_doit_as_IPython_magic.
@ankostis , since you wrote the original code can you help review this? Thanks @tonyfast , it looks better but a few questions:
|
|
have you noticed your changes broke the build? |
load_ipython_extension is a function so it is True
Missed that. I sorted the pyflakes error and now everything passes. |
thanks. I have finally (squashed) and merged this. I tested it and it works fine :) Seems github is not smart enough to detect I merged manually. |
With this update
replaces
This works using
load_ipython_extension
instead ofregister_doit_as_IPython_magic
.Here is an example notebook with this change.