Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed MD5 test to also work if test file has been cloned with crlf endings #219

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

moltob
Copy link
Contributor

@moltob moltob commented Nov 3, 2017

While preparing my development environment for the clean/forget command, I stumbled upon a failing test on Windows, Python 3.6.3, resulting from the fact that my GIT was checking out with crlf, leading to a different MD5 hash value.

I fixed the test by allowing both, the lf and crlf based hashes to be accepted. I verified the added hash in http://onlinemd5.com/.

It's weird that appveyor does not catch this, it seems to clone with lf only... Is that possible?

@moltob moltob changed the title fixed MD5 test to also work if test file has with crlf endings fixed MD5 test to also work if test file has been cloned with crlf endings Nov 3, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+3.0e-05%) to 99.731% when pulling 4d1bd6d on moltob:master into 8e7405d on pydoit:master.

@schettino72 schettino72 merged commit 1a1c717 into pydoit:master Nov 9, 2017
@schettino72
Copy link
Member

Thanks.
Not really happy with checking the result against 2 values... hope i never have to change this 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants