Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes in the db after each task execution. #228

Closed
wants to merge 1 commit into from

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Jan 8, 2018

I no more need this since I use the Redis backend (#225) but it is something you should consider adding (at least with an option if you think it would be too costly for short tasks).
Thanks to this the task execution status is no more lost if doit crashes before the end, and it allows to monitor the progress while doit is still running (I will open another issue about this!).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0004%) to 99.732% when pulling 64f415d on saimn:sync into 6006b54 on pydoit:master.

@schettino72
Copy link
Member

I think we should just recommend people to use Redis if they want this because performance really sucks. I will leave this PR open so I remember to update the docs.

Or if anyone thinks this useful I could re-consider my decision...

@saimn
Copy link
Contributor Author

saimn commented Jan 18, 2018

It would be useful (even necessary) for something like #229, otherwise you cannot get the up-to-date status of tasks while doit is still running. I didn't measure the cost of this, but tasks that takes "some" time the cost quickly becomes negligible I guess. So the issue is really for short tasks.

@schettino72
Copy link
Member

ok. lets include this.

Copy link
Member

@schettino72 schettino72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • unit-tests
  • docs
  • command line option (should not be enabled by default)

@saimn
Copy link
Contributor Author

saimn commented Mar 19, 2018

If someone wants to take over from this, it could be useful for the report plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants