Add a command to recompute dependencies state #28
Conversation
|
Changes Unknown when pulling 216c69c on saimn:reset-dep into * on pydoit:master*. |
|
|
||
| class ResetDep(DoitCmdBase): | ||
| name = "reset-dep" | ||
| doc_purpose = "recompute the state of file dependencies" |
There was a problem hiding this comment.
what do you think of: "recompute and save the state of file dependencies without executing actions"
|
thanks for the patch. I just did a quick review. I will take a closer look on weekend... please add :
|
| dep_manager=pdepfile) | ||
| cmd_list._execute() | ||
| got = output.getvalue() | ||
| assert "processed t2\n" == got |
There was a problem hiding this comment.
Apart from checking the output "saying" the new value was saved, can it also check that the new value was actually saved ?
|
Please updated the files |
|
Hi @schettino72, |
| @@ -502,6 +501,12 @@ def get_value(self, task_id, key_name): | |||
| raise Exception(msg % (task_id, key_name)) | |||
| return values[key_name] | |||
|
|
|||
| def get_results(self, task_name): | |||
| """get all saved results from a task | |||
There was a problem hiding this comment.
Each task has only 1 result, so it doesnt make sense to say "get all". And the function should be called get_result().
|
Thanks for your work. No worries about taking a long time :) Please also update(merge) your branch with master (but dont squash your commits) |
| @@ -106,7 +106,10 @@ def print_usage(cmds): | |||
| print('') | |||
| print("Commands") | |||
| for cmd in sorted(six.itervalues(cmds), key=attrgetter('name')): | |||
| six.print_(" doit %s \t\t %s" % (cmd.name, cmd.doc_purpose)) | |||
| # the command name is padded with spaces and must be 16 character | |||
There was a problem hiding this comment.
it wont look that good but it is ok if the command has more that 16 chars.
|
merged. github doesnt detected the merge because I squashed your commits... thanks for the high quality patches! |
|
Looks good, thanks for the thorough review ! :) |
|
@saimn sometimes I feel bad for being so picky on reviews hehehe By the way, if you wish, you are welcome to get more involved with the project reviewing my commits and others. And I am looking forward for more contributions :) |
It is not a bad thing :D, I tend to do the same on my projects, and doit code base is quite complex with a lot of different use cases, so it's hard for a new contributor to understand every piece of code. |
Ref #25