Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Add Linear search and Queue #50

Merged
merged 4 commits into from
Apr 9, 2016
Merged

Add Linear search and Queue #50

merged 4 commits into from
Apr 9, 2016

Conversation

iamneha
Copy link
Contributor

@iamneha iamneha commented Apr 6, 2016

No description provided.

@iamneha
Copy link
Contributor Author

iamneha commented Apr 8, 2016

@aktech I think it is ok now, can you please check this.
I am ready with more algorithm once you merge this then I will send more PR

@CuriousLearner
Copy link
Member

@iamneha Just a quick suggestion, no need to wait till this PR is merged. You can work on different branches in git for submitting different PR's and when you get reviews, you just need to checkout on that particular branch and update.

Let me know if you need any help with it.

@iamneha
Copy link
Contributor Author

iamneha commented Apr 8, 2016

@CuriousLearner thank you for your reply and I will send more PR asap.

>>> linear_search(List, item)
2
"""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8: W293 blank line contains whitespace

@iamneha
Copy link
Contributor Author

iamneha commented Apr 9, 2016

@CuriousLearner @aktech add all changes

"""
Insert element in queue.
"""
self.List.append(item)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NameError: global name 'self' is not defined

@iamneha
Copy link
Contributor Author

iamneha commented Apr 9, 2016

@aktech check please

@aktech aktech added the First PR label Apr 9, 2016
@aktech
Copy link
Member

aktech commented Apr 9, 2016

It looks good to me. +1
Thanks for working on it.

@aktech aktech merged commit 25d38d0 into pydsa:master Apr 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants