Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Add Binary Tree implementation, tests #75

Merged
merged 2 commits into from
May 15, 2016

Conversation

rehassachdeva
Copy link
Contributor

references #4

Please review.

@goelakash
Copy link
Collaborator

goelakash commented Apr 30, 2016

Good work! @rehassachdeva . Few comments:

  1. delete is slightly trickier. You can only delete children node when they are leaf nodes, other wise you have to some adjustments. See this to understand more - http://www.geeksforgeeks.org/write-a-c-program-to-delete-a-tree/
    In case of two children nodes, you may choose to make any one of them as the new parent for the other node. Then follow that procedure recursively. You can use any traversal technique here.
  2. Add docstrings to functions to explain the arguments and the operations being performed on them.

@rehassachdeva
Copy link
Contributor Author

Hi @goelakash. Have made the necessary changes. Please check now

@goelakash
Copy link
Collaborator

goelakash commented May 1, 2016

@rehassachdeva Looks good to me. Can you please add some the docs as well?
@aktech Can we merge this?

@goelakash
Copy link
Collaborator

#74 Maybe we can have a separate traversal module, and use those for all tree data structures. @aktech @CuriousLearner What do you guys think?

@rehassachdeva
Copy link
Contributor Author

@goelakash Docs have already been added here #68. I'll add reference for binary_tree once this is merged?

@goelakash
Copy link
Collaborator

@rehassachdeva That sounds good.

@aktech
Copy link
Member

aktech commented May 13, 2016

@rehassachdeva Please fix conflicts.

@rehassachdeva
Copy link
Contributor Author

@aktech

@goelakash goelakash merged commit 6ba4dd0 into pydsa:master May 15, 2016
@goelakash goelakash mentioned this pull request May 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants