Add: tests #1061
Merged
Add: tests #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1061 +/- ##
==========================================
+ Coverage 78.59% 79.09% +0.49%
==========================================
Files 79 80 +1
Lines 1640 1674 +34
==========================================
+ Hits 1289 1324 +35
+ Misses 351 350 -1
Continue to review full report at Codecov.
|
|
@chfw @sunhailin-Leo 可以往这个分支上继续补充测试用例。 此分支目前还未准备好 merge |
chfw
reviewed
May 4, 2019
pyecharts/options/series_options.py
Outdated
| from ..commons.types import JSFunc, List, Numeric, Optional, Sequence, Tuple, Union | ||
|
|
||
|
|
||
| class BasicOpts: | ||
| pass | ||
| opts: Union[dict, Sequence, None] = None |
chfw
reviewed
May 4, 2019
| @@ -11,3 +14,61 @@ def test_bar_base(): | |||
| assert c.theme == "white" | |||
| assert c.renderer == "canvas" | |||
| c.render("render.html") | |||
|
|
|||
|
|
|||
| @patch("pyecharts.render.engine.write_utf8_html_file") | |||
There was a problem hiding this comment.
and will protect my SSD hard disk when running pyecharts unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本次 PR 内容，