PR: add pictorialbar chart type and fix some bugs #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1158 +/- ##
==========================================
+ Coverage 86.57% 86.94% +0.36%
==========================================
Files 90 92 +2
Lines 1981 2014 +33
==========================================
+ Hits 1715 1751 +36
+ Misses 266 263 -3
Continue to review full report at Codecov.
|
sunhailin-Leo
previously approved these changes
May 31, 2019
chfw
reviewed
May 31, 2019
pyecharts/charts/basic_charts/geo.py
Outdated
| @@ -53,8 +53,9 @@ def add( | |||
| self._zlevel += 1 | |||
|
|
|||
| data = [] | |||
| if type_ == ChartType.LINES and self._coordinate_system == "bmap": | |||
| data = data_pair | |||
| if self._coordinate_system == "bmap": | |||
There was a problem hiding this comment.
GeoChartBase shall not take care of the details of child. Otherwise, all children come back to base for help.
chenjiandongx
commented
Jun 1, 2019
| else: | ||
| lng, lat = self.get_coordinate(n) | ||
| data.append({"name": n, "value": [lng, lat, v]}) | ||
| data = self._feed_data(data_pair, type_) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
本次 PR 内容，