New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart3D is added to absorb all commonalities in 3D charts #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #550 +/- ##
==========================================
+ Coverage 98.82% 98.82% +<.01%
==========================================
Files 96 96
Lines 3659 3665 +6
==========================================
+ Hits 3616 3622 +6
Misses 43 43
Continue to review full report at Codecov.
|
有点问题 等我 commit |
chenjiandongx
approved these changes
May 11, 2018
chenjiandongx
pushed a commit
that referenced
this pull request
Mar 26, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure * 📚 update documentation * 🔨 code refactor geolines * 📰 add missing test fixture * Update: 图形类部分细节修改 * Fixed: make flake5 happy * Update: micro docs update
chenjiandongx
pushed a commit
that referenced
this pull request
Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure * 📚 update documentation * 🔨 code refactor geolines * 📰 add missing test fixture * Update: 图形类部分细节修改 * Fixed: make flake5 happy * Update: micro docs update
chenjiandongx
pushed a commit
that referenced
this pull request
Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure * 📚 update documentation * 🔨 code refactor geolines * 📰 add missing test fixture * Update: 图形类部分细节修改 * Fixed: make flake5 happy * Update: micro docs update
chenjiandongx
pushed a commit
that referenced
this pull request
Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure * 📚 update documentation * 🔨 code refactor geolines * 📰 add missing test fixture * Update: 图形类部分细节修改 * Fixed: make flake5 happy * Update: micro docs update
chenjiandongx
pushed a commit
that referenced
this pull request
Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure * 📚 update documentation * 🔨 code refactor geolines * 📰 add missing test fixture * Update: 图形类部分细节修改 * Fixed: make flake5 happy * Update: micro docs update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chart3D
-> Line3D
-> Bar3D
-> Scatter3D
Geo
-> GeoLines