Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart3D is added to absorb all commonalities in 3D charts #550

Merged
merged 7 commits into from May 11, 2018

Conversation

chfw
Copy link
Member

@chfw chfw commented May 10, 2018

Chart3D
-> Line3D
-> Bar3D
-> Scatter3D

screen shot 2018-05-10 at 20 18 45

Geo
-> GeoLines

screen shot 2018-05-10 at 22 08 34

@codecov-io
Copy link

codecov-io commented May 10, 2018

Codecov Report

Merging #550 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #550      +/-   ##
==========================================
+ Coverage   98.82%   98.82%   +<.01%     
==========================================
  Files          96       96              
  Lines        3659     3665       +6     
==========================================
+ Hits         3616     3622       +6     
  Misses         43       43
Impacted Files Coverage Δ
pyecharts/charts/geo.py 100% <ø> (ø) ⬆️
pyecharts/conf.py 98% <ø> (ø) ⬆️
pyecharts/charts/map.py 100% <ø> (ø) ⬆️
pyecharts/utils/__init__.py 97.18% <100%> (ø) ⬆️
pyecharts/charts/geolines.py 100% <100%> (ø) ⬆️
pyecharts/charts/line3D.py 100% <100%> (ø) ⬆️
pyecharts/charts/funnel.py 100% <100%> (ø) ⬆️
test/test_options.py 100% <100%> (ø) ⬆️
pyecharts/chart.py 94.87% <100%> (+2.87%) ⬆️
pyecharts/charts/bar3D.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a534ecb...1c16a9f. Read the comment docs.

@chenjiandongx
Copy link
Member

有点问题 等我 commit

@chenjiandongx chenjiandongx merged commit d517dd8 into dev May 11, 2018
@chenjiandongx chenjiandongx deleted the pylinting branch May 11, 2018 06:29
chenjiandongx pushed a commit that referenced this pull request Mar 26, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure

* 📚 update documentation

* 🔨 code refactor geolines

* 📰 add missing test fixture

* Update: 图形类部分细节修改

* Fixed: make flake5 happy

* Update: micro docs update
chenjiandongx pushed a commit that referenced this pull request Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure

* 📚 update documentation

* 🔨 code refactor geolines

* 📰 add missing test fixture

* Update: 图形类部分细节修改

* Fixed: make flake5 happy

* Update: micro docs update
chenjiandongx pushed a commit that referenced this pull request Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure

* 📚 update documentation

* 🔨 code refactor geolines

* 📰 add missing test fixture

* Update: 图形类部分细节修改

* Fixed: make flake5 happy

* Update: micro docs update
chenjiandongx pushed a commit that referenced this pull request Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure

* 📚 update documentation

* 🔨 code refactor geolines

* 📰 add missing test fixture

* Update: 图形类部分细节修改

* Fixed: make flake5 happy

* Update: micro docs update
chenjiandongx pushed a commit that referenced this pull request Mar 30, 2019
* 🔨 code refactoring and 🔥 remove duplicated code, collapse chart inheritance structure

* 📚 update documentation

* 🔨 code refactor geolines

* 📰 add missing test fixture

* Update: 图形类部分细节修改

* Fixed: make flake5 happy

* Update: micro docs update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants