Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geolines data value #566

Merged
merged 7 commits into from May 15, 2018
Merged

Geolines data value #566

merged 7 commits into from May 15, 2018

Conversation

chenjiandongx
Copy link
Member

本次 PR 内容，

@codecov-io
Copy link

codecov-io commented May 15, 2018 •
edited

Codecov Report

Merging #566 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #566      +/-   ##
==========================================
+ Coverage   98.89%   98.89%   +<.01%     
==========================================
  Files          96       96              
  Lines        3700     3710      +10     
==========================================
+ Hits         3659     3669      +10     
  Misses         41       41
Impacted Files Coverage Δ
pyecharts/echarts/option.py 97.65% <ø> (ø) ⬆️
pyecharts/charts/geolines.py 100% <100%> (ø) ⬆️
test/test_geolines.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa50fa...f79bc58. Read the comment docs.

chfw
chfw reviewed May 15, 2018
View reviewed changes
pyecharts/charts/geolines.py
@@ -161,6 +170,7 @@ def add(
"symbolSize": 10,
"data": _data_scatter,
"label": chart["label"],
"tooltip": {"formatter": "{b}"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tooltip formatter could a function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

考虑过这点，这里只是用于 scatter 图中点的 tooltip，该点的数值无意义，所以只显示城市名即可。没必要提供参数让用户修改。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是有意而为之

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

chfw
chfw reviewed May 15, 2018
View reviewed changes
pyecharts/charts/geolines.py Outdated
_from_name, _to_name = d
for element in data:
assert len(element) >= 2
_lines_value = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_line_value please, it is a single value.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

chfw
chfw reviewed May 15, 2018
View reviewed changes
test/test_geolines.py Outdated
"从广州出发", data_guangzhou, tooltip_formatter="{a} : {c}", **style_geo
)
lines.render()
html_content = lines._repr_html_()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use get_default_rendering_file_content()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils.py https://github.com/pyecharts/pyecharts/blob/master/test/utils.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

chfw
chfw approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@chfw chfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@chfw chfw merged commit 9d06943 into dev May 15, 2018
@chfw chfw deleted the geolines-data-value branch May 15, 2018 12:32
chenjiandongx added a commit that referenced this pull request May 16, 2018
@chenjiandongx
Geolines data value (#566)
3c05d0f 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 26, 2019
@chenjiandongx @chfw
Geolines data value (#566)
ff9f677 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 26, 2019
@chenjiandongx
Geolines data value (#566)
c1bf718 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx @chfw
Geolines data value (#566)
50c66be 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx
Geolines data value (#566)
8f02094 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx @chfw
Geolines data value (#566)
6a85607 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx
Geolines data value (#566)
0285c06 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx @chfw
Geolines data value (#566)
0f4cdf2 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx
Geolines data value (#566)
60cb8de 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx @chfw
Geolines data value (#566)
bdea95e 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
chenjiandongx added a commit that referenced this pull request Mar 30, 2019
@chenjiandongx
Geolines data value (#566)
8b5dba9 
* Update: 更新 x,y 轴 formatter 参数注释

* #565 Geolines 图数据项可以新增数值维度

* Update: charts docs update

* Fix: fixed bronken test

* Update: 更新 github ISSUE 及 PR 提交模板

* Update: lines -> line

* Update: 删除无用语句
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfw chfw chfw approved these changes

@kinegratii kinegratii Awaiting requested review from kinegratii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chenjiandongx @codecov-io @chfw